Check for perl based on location of Ska Python

sot / starcheck

BSD 3-Clause "New" or "Revised" License

3 stars 0 forks source link

Check for perl based on location of Ska Python #347

Closed taldcroft closed 4 years ago

taldcroft commented 4 years ago

Description

This is basically what is used for the sandbox starcheck, and it appears to work fine.

Testing

[N/A] Passes unit tests
[x] Functional testing (partial)

Minimal testing

I installed this into a ska3-shiny environment on Mac and confirmed that it ran without error on a representative recent set of load products.

jeanconn commented 4 years ago

Still would need testing on ska3-flight to go in master but besides that fine (I suppose this would technically need a not /proj/sot/ska3/flight root test environment).

jeanconn commented 4 years ago

This looks to work for me in a root linux test ska. The only perfect testing issue is that is still a bit different from the call to /proj/sot/ska/bin/starcheck that calls /proj/sot/ska3/flight/bin/starcheck. I'm good with the change.

taldcroft commented 4 years ago

Should we put this into a shiny branch to punt off needing to test twice (in current ska3-flight and shiny?). That's kind of the way I've been going with changes like this.

jeanconn commented 4 years ago

For the launcher, I've already done the integration testing that is required for master promotion, so this can just go in master now. Because of the nature of the launcher, I still note that this is a change that should be checked after promotion (as in, this kind of change should get a "SOT MP should run this after promotion" test). No big deal. I would like to get a few more changes in for starcheck soon and haven't thought of anything that really needs a shiny branch.