change yaml loading to avoid warning

sot / starcheck

BSD 3-Clause "New" or "Revised" License

3 stars 0 forks source link

change yaml loading to avoid warning #357

Closed javierggt closed 4 years ago

javierggt commented 4 years ago

Description

This just changes theloading statement according to https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation

It should fix the test failure in post_check_logs.py

Testing

[ ] ~Passes unit tests on MacOS, linux, Windows (at least one required)~ (this has no unit tests)
[x] Functional testing

Fixes #

jeanconn commented 4 years ago

@taldcroft was saying the new convention should be to use safe_load IIRC https://github.com/sot/arc/pull/55#pullrequestreview-457059558 . I note I have this in the WIP I've been working https://github.com/sot/starcheck/pull/327/commits/4f81e3509bfade3c08acec5cc33fae353469f80a but I can rebase as necessary.

javierggt commented 4 years ago

I understand it can be there. I just want to get the dashboard green.

javierggt commented 4 years ago

After this, only kadi test_regress.py would be failing.

jeanconn commented 4 years ago

Sure. That's fine. I suppose technically one of us should run a test schedule to satisfy functional testing. It has been working fine in my WIP branch but that's not quite the same thing.

jeanconn commented 4 years ago

I ran OCT0920A with yaml-warning branch for the record and didn't get any new warnings or errors.