Add suspect bad pixel region to bad pixels

sot / starcheck

BSD 3-Clause "New" or "Revised" License

3 stars 0 forks source link

Add suspect bad pixel region to bad pixels #373

Closed jeanconn closed 3 years ago

jeanconn commented 3 years ago

Description

Add bad pixel region to check for stars too close to the CCD region in which diminished star mags are apparent when star dithers through. See slack aspect-team conversation Jun 25, 2021 (search "composite image of the bad region for all observations since 2016").

Testing

[x] Functional testing

Ran on MAR3020A and JUL0719A and confirmed obsids 22957 and 48040 are marked with CRITICAL warnings with stars near a bad pixel.

jeanconn commented 3 years ago

I'd prefer to do this as part of #327 , but given the possible impact, we might want to just toss this in as an interim check.

jeanconn commented 3 years ago

Additionally, I don't have a strong signal for the extent of what I'm calling a bad pixel region, but these numbers seem in the ballpark.

jeanconn commented 3 years ago

Great. Thanks. This update is, as you saw, super trivial to get this protection in.

taldcroft commented 3 years ago

Now we can at least run a dev starcheck on the side for load review to catch this issue.