search

sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Move the bright limit to 5.2 in code and checklist #377

Closed jeanconn closed 3 years ago

jeanconn commented 3 years ago

Description

Move the bright limit warnings by 0.6 mags

Not sure how much we want to finesse the limits for the load review checklist and the starcheck warning (or just defer to the sparkles warning based on sigma)... or if we should just push them brighter by 0.6 mags.

Testing

For functional testing, I ran on the SEP2021B loads flight and test and confirmed the warnings on the 5.8 bright stars are no longer present.

1,2c1,2
<  ------------  Starcheck 13.12.0    -----------------
<  Run on Mon Oct 25 18:01:47 EDT 2021 by jeanconn from fido.cfa.harvard.edu
---
>  ------------  Starcheck 13.12.1.dev3+gdc48532    -----------------
>  Run on Mon Oct 25 18:10:53 EDT 2021 by jeanconn from fido.cfa.harvard.edu
49c49
< OBSID = 26134 at 2021:264:09:29:18.106   6.4 ACQ | 2.8 GUI | Critical: 5 Warn: 3 Caution: 7
---
> OBSID = 26134 at 2021:264:09:29:18.106   6.4 ACQ | 2.8 GUI | Critical: 4 Warn: 3 Caution: 7
62c62
< OBSID = 24300 at 2021:266:06:48:30.941   6.0 ACQ | 3.5 GUI | Critical: 5 Warn: 1 Caution: 6
---
> OBSID = 24300 at 2021:266:06:48:30.941   6.0 ACQ | 3.5 GUI | Critical: 4 Warn: 1 Caution: 6
66c66
< OBSID = 24303 at 2021:267:01:51:39.371   6.0 ACQ | 2.8 GUI | Critical: 5 Warn: 3 Caution: 6
---
> OBSID = 24303 at 2021:267:01:51:39.371   6.0 ACQ | 2.8 GUI | Critical: 4 Warn: 3 Caution: 6
243d242
< >> CRITICAL: [ 8] Magnitude. Guide star  5.836
732d730
< >> CRITICAL: [ 8] Magnitude. Guide star  5.836
845d842
< >> CRITICAL: [ 8] Magnitude. Guide star  5.836
jeanconn commented 3 years ago

Checklist and change approved by SSAWG. Still needs note of functional test.