search

sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Add track overlap check #380

Closed jeanconn closed 2 years ago

jeanconn commented 2 years ago

Description

Add track overlap check.

The PEA discards a readout window that overlaps with another window.  Review of the guide star tracking data (for the agasc supplement update) from the NOV2921A schedule shows that a guide star was frequently lost due to overlap with another guide star window.    The existing spoiler checks in selection and review have prevented most overlapping stars from occurring, but the NOV2921A star selection shows that two selectable guide stars could be selected with the existing code within 35 arcsecs and have no starcheck warning.  This PR  adds a check that two tracked items (MON, FID, GUI, BOT) are not within 60 arcsecs.

Testing

Screen Shot 2021-12-19 at 9 39 06 PM
taldcroft commented 2 years ago

Don't put permanent output into a tmp dir : Ran on NOV2921A, output https://icxc.cfa.harvard.edu/aspect/tmp/starcheck-pr380/starcheck.html#obsid45890.

taldcroft commented 2 years ago

The description is too terse. Think of the PR description being something that external reviewers might quickly glance at, or more likely that we might view in 5 years.

taldcroft commented 2 years ago

Can you copy/paste the relevant starcheck output into the description in case someone is viewing this without being on VPN?

jeanconn commented 2 years ago

Ah. If we've decided we want the test outputs to be permanent that's fine.

jeanconn commented 2 years ago

Or should the output just live in the PR? Maybe that is the most sustainable choice.