search

sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

prevent matplotlib warning #381

Closed javierggt closed 2 years ago

javierggt commented 2 years ago

Description

This PR prevents the warning that appeared in sot/skare3/pull/755:

linestyle is redundantly defined by the 'linestyle' keyword argument and the fmt string.

which occurs because both fmt and linestyle/color are given.

Testing

Fixes #

jeanconn commented 2 years ago

This one isn't quite ready, if I've tested correctly:

Flight: flight_ccd_temperature

Test: test_ccd_temperature

I think it should still explicitly define no marker in the new call.

taldcroft commented 2 years ago

Agreed with @jeanconn here. The default for plot_date has fmt='o'. https://matplotlib.org/stable/api/_as_gen/matplotlib.pyplot.plot_date.html

javierggt commented 2 years ago

Yup. Fixed it.

jeanconn commented 2 years ago

Looks good to me now:

test_ccd_temperature2

This output can count as functional testing.