Closed jeanconn closed 1 year ago
This PR achieves the stated objective with a minimal footprint.
However, looking at the code, the logic could use improvement. E.g. if dither of 8x20 is passed then it declares that as standard dither for acis
. From what I can see the return value (e.g. acis
) is not checked, so no warning would be issued even for an HRC observation with 8x8 dither. (HRC review would catch this though).
It's probably worth cleaning up this whole function, probably taking the detector as an argument and always returning a bool (0 or 1).
I am adding a commit to switch the dither periods, because they are switched in recent loads. I used this branch, including my commit, to review the DEC1922 loads and can confirm that the only change with the current flight review is the disappearance of the non-standard dither warnings (except the three observations with actual non-standard dither).
I also had to rebase on master for things to work, because of window size warnings and high-IR zone checks.
With regard to corner cases; the recent 16x8 observations have different periods than I (or this code) expected, but maybe that is still fine to push this as an incremental improvement.
Description
Add 16 arcsec to 'standard' dither in y and z
Interface impacts
None
Testing
Unit tests
Functional tests
Removes "Non-standard dither" CAUTION on obsid 21250 which is 16x16.