Closed taldcroft closed 2 years ago
It seems like it would be fine to print out the kadi scenario around https://github.com/sot/starcheck/blob/69c72ac732acbc609d70799aa6d04720dc1a62a6/starcheck/src/starcheck.pl#L567 (either for the non-default case or just in general)
Running starcheck gives this red output unless the scenario is flight
:
just not sure in this case if the default setting needs to be conditional.
I spent about 3 hours today improving on_head_network
and I'm sure that in 3 months I'll forget the right way to run starcheck standalone so it uses the commands archive v2 that I spent months working on. (The answer being the non-obvious env KADI_SCENARIO="" starcheck
. So please just throw me a bone here.
Sure. I just wanted to make sure I understood this and thought this was an area where it could perhaps be simpler. Fine to introduce a little complexity for convenience and a plus overall that the on_head_network should be more robust (instead of dealing with oddities there one machine at a time).
I approved and tested this before the printing change. I note, I'm seeing "Kadi scenario: None" on fido, so I'm not sure that the environment variable is actually set for the perl code.
I put in another PR for this issue https://github.com/sot/starcheck/pull/394 as getting the env var from the Python side seems to give the correct answer.
Description
For production use of starcheck (run by SOT MP on HEAD), we should use the
flight
scenario by default so that it does not use external network resources. In particular using OCCweb requires credentials that may not be available.This uses on_head_network() to decide to default to
flight
.Interface impacts
Testing
Unit tests
Functional tests
On HEAD (kady)
On Mac