search

sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Fix performance issue in get_fid_actions #392

Closed taldcroft closed 2 years ago

taldcroft commented 2 years ago

Description

There was a bug in get_fid_actions that was causing the code to run on the entire mission fid history each time.

This fix reduces the time of that step by about 30 seconds.

Interface impacts

None

Testing

Unit tests

Functional tests

I ran this for current master and this branch:

./sandbox_starcheck -dir ~/ska/data/mpcrit1/mplogs/2022/AUG2922/ofls

The diff of starcheck.txt was only the expected change:

$ diff starcheck.txt starcheck-new.txt
1,2c1,2
<  ------------  Starcheck 13.15.2.dev5+g5fd629a    -----------------
<  Run on Mon Aug 29 09:09:25 EDT 2022 by aldcroft from daze
---
>  ------------  Starcheck 13.15.2.dev5+g5fd629a.d20220829    -----------------
>  Run on Mon Aug 29 09:06:57 EDT 2022 by aldcroft from daze