Fix benign dither bug (Use of uninitialized value)
https://github.com/sot/starcheck/pull/390 introduced this tiny bug by checking for the empty string instead of a defined value. We could use the empty string and change the check or update the check to use defined(). This PR uses defined().
Fixes warning:
Use of uninitialized value $dither_error in string ne at ./starcheck/src/starcheck.pl line 280.
Interface impacts
Testing
Unit tests
[x] No unit tests
Functional tests
Ran with and without this change, and with the changes in this PR the warning
Use of uninitialized value $dither_error in string ne at ./starcheck/src/starcheck.pl line 280.
is not present on a load without dither issues. I ran on an old AUG2322 with dither mismatch with history and the dither warning printing at console and in starcheck html output is preserved and correct.
Description
Fix benign dither bug (Use of uninitialized value)
https://github.com/sot/starcheck/pull/390 introduced this tiny bug by checking for the empty string instead of a defined value. We could use the empty string and change the check or update the check to use defined(). This PR uses defined().
Fixes warning:
Use of uninitialized value $dither_error in string ne at ./starcheck/src/starcheck.pl line 280.
Interface impacts
Testing
Unit tests
Functional tests
Ran with and without this change, and with the changes in this PR the warning
is not present on a load without dither issues. I ran on an old AUG2322 with dither mismatch with history and the dither warning printing at console and in starcheck html output is preserved and correct.