search

sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Add High IR Zone PCAD checks #395

Closed jeanconn closed 2 years ago

jeanconn commented 2 years ago

Description

Add High IR Zone PCAD checks

Check that there are no states with pcad_mode != 'NMAN' overlapping the High IR Zone times.

This adds a text file that just prints the pcad mode and times of all states that overlap the High IR Zone.

Interface impacts

Adds a new text file that will just be used to display output for starcheck.

Testing

Unit tests

Functional tests

Ran on JAN3122A schedule and see expected top-level warning. Output at https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr395/test_jan3122a.html

Ran on AUG2922A schedule and see expected top-level OK. https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr395/test_aug2922a.html

Diffs from flight (3.15.1) https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr395/diff_aug2922a.html https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr395/diff_jan3122a.html

jeanconn commented 2 years ago

This doesn't need to go in 2022.9 but it might be a nice-to-have.

jeanconn commented 2 years ago

I had rebased since running the outputs anyway, so I redid the test runs with output in the icxc test review output area. I did diffs against flight (diffs against master would also be valuable and the starcheck tests should probably be run from a commands v2 environment with the rest of 2022.9... but for the high IR zone printing I think this is fine).