Closed taldcroft closed 1 year ago
What was the hidden dependence? Or, equivalently, how does this fix it?
The call to kadi get_cmds
to set the dither history. So not exactly "hidden", but we both missed this in my patch that just addressed the call in calc_ccd_temps
.
And the fix is to set the environment variable early in the perl script before anything else happens.
Makes sense. Thanks!
@jeanconn - just a reminder here that you should take over the functional testing of this, which I can then review.
@taldcroft I don't think I can request a review on it from you, but is that what you had in mind for functional testing or would you like some other variations?
@taldcroft figured I'd check once more about this now that you are back.
@jeanconn - I have reviewed your functional testing and it looks fine. I pushed another commit so I'll re-request a final review from you. I'll update the functional test description momentarily.
Description
Fixes the issue noted on slack (#missionplanning "SOT MP run of starcheck did not generate the expected output files for the OCT1722B products"), that get_dither_kadi_state would run before
KADI_SCENARIO=flight
was set, causing HEAD starcheck to still have a network dependence for SOT MP's run of the tool.In the course of implementing the fix, some refactoring and rework of existing code was useful.
Interface impacts
Testing
Unit tests
Functional tests
Disabled occweb access and confirmed that master fails to use 'flight' scenario:
Confirmed that this PR (with the same disabled .netrc etc) works and that KADI_SCENARIO is set to flight before/for all kadi command queries.
Testing of 403a1d6
By default the output does not include any kadi logging output. Confirmed this with:
Also ran with
-verbose=0
and got the same results. Then ran with-verbose=2
and got kadiDEBUG
output:Previous behavior reported by @jeanconn, NO LONGER accurate
The new STDERR output has "Getting commands from archive only" whenever a call was made to kadi commands. Seems fine. The first call also shows when the commands were loaded (happens once)
This is fine as well.