Closed jeanconn closed 1 year ago
This works for me.
and while you are at it, can you fix the indentation in that block? 😄
What's our indentation standard for perl anyway? I thought this looked OK actually.
I don't know what are your coding standards for perl, but indentation is always a good idea. The main idea is that the indentation should tell you right away what is the nesting level. This is true even in languages that use brackets to denote scope.
In this case, I was stumped when reading the code and had to go line by line to match the brackets. This is a small block so it does not matter much, but still...
You've lost me. I thought END block code should be indented, so it is, and each block that is an if statement is also indented. But it looks like some if it is tabs instead of spaces?
I'll fix the tabs instead of spaces.
ah, I see, it's a mixture of tabs and spaces. That should be forbidden in any coding standard 😉
So, whatever...
For "indentation standard" I really meant "what should we have for vscode and for perltidy to get something that displays ok". For perl, I was still sometimes opening this up in emacs which I think is happily using a mix of tabs and spaces that did not work for you. Editing it with "default" vscode" seems to have also left a mix of tabs and spaces but is now displaying them differently? I have stopped caring.
I assume you are waiting for @taldcroft but it seems ok to me.
Yes, it would be good to have a review, but I just requested one from you which I think would be fine for this radical change.
🤣
Agreed w/ @javierggt that we should apply some formatting standards to starcheck, and ... https://github.com/sot/starcheck/pull/405
Description
Save and regurgitate exit status at END
Fixes ska_testr run test which was implicitly checking exit status.
Interface impacts
Testing
Unit tests
Functional tests
I confirmed that the "nominal exit" code is now 0 instead of 9 and that simple errors for missing or not existing directories for products give non-zero status: