sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

check_bright_perigee inconsistent for vehicle products #407

Open jeanconn opened 1 year ago

jeanconn commented 1 year ago

check_bright_perigee uses radmon enable/disable to define which ERs are "perigee" ERs. Radmon enable/disable isn't in the vehicle backstop so this doesn't work.

I noticed this in the JAN3023U test products diff, as the vehicle products show a bright guide count for an ER that is not in perigee. It looks like for vehicle products, check_bright_perigee will just end up using the radmon status as defined by the last line in History/RADMON as the radmon status for the "week". This is a benign issue but it would probably be more consistent to just check all ERs for bright count (instead of just perigee ones) when in vehicle mode.

https://icxc.harvard.edu/mp/mplogs/OFLS_testing/2023/JAN3023/oflsu/diff_starcheck.html