sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Update for expanded high-IR zone #413

Closed jeanconn closed 1 year ago

jeanconn commented 1 year ago

Description

Extend the high IR zone to 20 minutes after perigee for the high IR zone keep-out check.

Interface impacts

Testing

Unit tests

Functional tests

Ran on one week (JUN0523) with the previous pre-perigee zone, and two weeks (JUN1923 and JUN2623) with the new 30-before-20-after zone in products.

Output at https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr413

jeanconn-fido> more run.sh
# JUN0523 week 
/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2023/JUN0523/oflsa -out jun0523a_test
/proj/sot/ska3/flight/bin/starcheck -dir /data/mpcrit1/mplogs/2023/JUN0523/oflsa -out jun0523a_flight
/proj/sot/ska/bin/diff2html jun0523a_flight.txt jun0523a_test.txt > jun0523a_diff.html

# JUN1923 week 
/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2023/JUN1923/oflsa -out jun1923a_test
/proj/sot/ska3/flight/bin/starcheck -dir /data/mpcrit1/mplogs/2023/JUN1923/oflsa -out jun1923a_flight
/proj/sot/ska/bin/diff2html jun1923a_flight.txt jun1923a_test.txt > jun1923a_diff.html

# JUN2623 week 
/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2023/JUN2623/oflsa -out jun2623a_test
/proj/sot/ska3/flight/bin/starcheck -dir /data/mpcrit1/mplogs/2023/JUN2623/oflsa -out jun2623a_flight
/proj/sot/ska/bin/diff2html jun2623a_flight.txt jun2623a_test.txt > jun2623a_diff.html
taldcroft commented 1 year ago

At first look this seems OK.

jeanconn commented 1 year ago

For functional testing, it probably makes sense to just show this week passing and some previous week (before the zone change) failing. I don't think we care about regression testing here -- and thus don't care about making this date dependent or adding a cmdline option.