search

sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Check the pixel mode for ORs is set to ORIG #415

Closed jeanconn closed 1 year ago

jeanconn commented 1 year ago

Description

Check the PEA pixel mode for ORs is set to ORIG

These are PEA1 commands, corresponding PEA2 commands are AAC2PTLM and AAC2BGD.

Interface impacts

Testing

Tested out of ska3-matlab-2023.4rc6 though that should not be required.

Unit tests

Functional tests

I edited JUL0323A backstop to remove the first command to switch back to ORIG after perigee for this output:

https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr414/jul0323a_orig_removed.html

I edited JUL0323A backstop to move the first command to switch back to ORIG after perigee to be in the next OR for this output:

https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr414/jul0323a_orig_moved.html

taldcroft commented 1 year ago

The new custom pixel state is great!

I think there is a tidier path to getting the commands and subsequent states that reuses functionality built into kadi. See: https://gist.github.com/taldcroft/fb0998994cfebc22d06791dc5540c723

taldcroft commented 1 year ago

I would suggest to close this for now. If we get back to switching pixel mode again we can re-open it.

javierggt commented 1 year ago

NOTE: This PR was closed, because pixel mode is not going to change in the near future.

After backstop 7.9 (FSDS-83), there were some changes in backstop. Specifically:

Similarly, if the background algorithm is set: