search

sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Ignore mag clipping chandra_aca warnings #416

Closed jeanconn closed 1 year ago

jeanconn commented 1 year ago

Description

Ignore mag clipping chandra_aca star_probs warnings from the acquisition model.

Fixes #414

Interface impacts

Testing

Unit tests

Functional tests

On fido/linux, with CHANDRA_MODELS_REPO_DIR set to /home/jeanconn/git/chandra_models and that repo checked out to have a version of the recent acquisition model in it, I confirmed that master gives these warnings

Writing plot file jul0323t/ccd_temperature.png
/fido.real/conda/envs/ska3-matlab-2023.4rc6/lib/python3.10/site-packages/chandra_aca/star_probs.py:349: UserWarning: 
Model grid-* computed between mag <= 5.0 <= 10.75, clipping input mag(s) outside that range.
  warnings.warn(
Checking star catalog for obsid 44375

and they aren't present with this PR.

Writing plot file jul0323t/ccd_temperature.png
Checking star catalog for obsid 44375
Checking star catalog for obsid 44374
jeanconn commented 1 year ago

I'm a little surprised that the mags are clipped at 10.75 from the acquisition model and don't quite remember what that means for various temperatures, but that's neither here nor there for this PR. There is the question about if starcheck should be checking anything else when the new acquisition model is promoted. @taldcroft ?

jeanconn commented 1 year ago

I was seeing this warning for every catalog, but it looks like there aren't that any fainter-than-10.75 in the actual catalogs of the week I was using in testing, so likely these come up via some other method (probabilities of the not-selected candidates). From a starcheck perspective we probably want to warn with a CAUTION if the mag of an acq star is fainter than 10.75 or not include it in the acquisition probability.

jeanconn commented 1 year ago

Thanks for doing that sanity check on the super faint stars! Though I suppose if more fields are passable for guide with the dynamic background bonus, maybe we'll find ourselves on the P2=2.0 edge more frequently? Will see!