search

sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Add a unit test for dyn bgd hotpix imposter calc #418

Closed jeanconn closed 1 year ago

jeanconn commented 1 year ago

Description

Add a unit test for dyn bgd hotpix imposter calc. Maybe it is a bridge too far for the #412 PR, but we could start to accumulate Python unit tests here as we go. This is not a particularly clean unit test; I suppose it would be better to ask sparkles what we want for dyn_bgd_n_faint and dyn_bgd_dt_ccd or some such? But this does work as a functional test for the imposter calc.

This addresses the issue at the end of #412 that the functional testing of the imposter calculation was not demonstrated.

Interface impacts

Testing

I tested this with install testing into my ska3-matlab-2023.4rc6 environment.

Unit tests

Independent check of unit tests by [REVIEWER NAME]

Functional tests

No functional testing.

jeanconn commented 1 year ago

@taldcroft I don't know if we actually want to merge this or something like it, but it seemed a reasonable way to document what I did for functional test.

jeanconn commented 1 year ago

OK. Thanks. I just committed your changes and re-ran the test successfully.

jeanconn commented 1 year ago

This is a PR against #412, so my preference would be to get #412 approved without this, get this approved, and then merge them both.

jeanconn commented 1 year ago

Thanks! And I'm fine with making those regex changes if we are fine with a "starcheck still seemed to run ok" test for the record as enough testing for that.

jeanconn commented 1 year ago

Though actually... what are you doing to see those pcad_att_check warnings?