Use ccd_temp instead of t_ccd from dark cal data.
The 't_ccd' value is only available for acdc dark cals starting in 2019. The ccd_temp value is equal to t_ccd for modern calibrations and exists for the older ones.
Interface impacts
Testing
Unit tests
[X] Mac
Independent check of unit tests by [REVIEWER NAME]
[ ] [PLATFORM]:
Functional tests
Functionally, the ska_testr regression test runs MAY2019A as the test and that failed against master with:
Traceback (most recent call last):
File "/Users/jean/miniconda3/envs/ska3-matlab-2023.4rc6/lib/python3.10/site-packages/starcheck/server.py", line 71, in handle
result = func(*args, **kwargs)
File "/Users/jean/miniconda3/envs/ska3-matlab-2023.4rc6/lib/python3.10/site-packages/starcheck/utils.py", line 329, in check_hot_pix
dark_t_ccd = dark_props["t_ccd"]
KeyError: 't_ccd'
Description
Use ccd_temp instead of t_ccd from dark cal data. The 't_ccd' value is only available for acdc dark cals starting in 2019. The ccd_temp value is equal to t_ccd for modern calibrations and exists for the older ones.
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Functionally, the ska_testr regression test runs MAY2019A as the test and that failed against master with:
With this PR there is no exception.