Closed jeanconn closed 12 months ago
Update the "too cold" warning to use the acquisition temperature, as this check is about fid lights.
Closes #386
Run against a recent ska3 masters env, though this is not required for this change.
Independent check of unit tests by [REVIEWER NAME]
Single regression/functional test output at https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr424/
For obsid 26644 the violation of the -14C threshold would have happened at the end of the observation, so changing the check to be wrt acquisition temperature means that the warning is not thrown.
(checkout starcheck master) /home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2022/NOV2122/oflsa/ -out nov2122a_master (checkout this PR branch) /home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2022/NOV2122/oflsa/ -out nov2122a_test diff -u nov2122a_master.txt nov2122a_test.txt > diff.txt
Description
Update the "too cold" warning to use the acquisition temperature, as this check is about fid lights.
Closes #386
Interface impacts
Testing
Run against a recent ska3 masters env, though this is not required for this change.
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Single regression/functional test output at https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr424/
For obsid 26644 the violation of the -14C threshold would have happened at the end of the observation, so changing the check to be wrt acquisition temperature means that the warning is not thrown.