Update the temperature clipping for the acquisition model to clip to the range for the current grid-* model. It would be better if this was taken from model itself, but this does not change frequently.
Interface impacts
None
Testing
Unit tests
[x] Linux
(ska3-masters) jeanconn-fido> git rev-parse HEAD
1524a7bf9b4c8d270121ac14109a128bc5e612c9
(ska3-masters) jeanconn-fido> pytest
======================================================================= test session starts ========================================================================
platform linux -- Python 3.10.8, pytest-7.2.1, pluggy-1.0.0
rootdir: /proj/sot/ska/jeanproj/git/starcheck
plugins: timeout-2.1.0, anyio-3.6.2
collected 14 items
starcheck/tests/test_state_checks.py ............. [ 92%]
starcheck/tests/test_utils.py . [100%]
========================================================================= warnings summary =========================================================================
../../../../../../fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/numexpr/expressions.py:21
../../../../../../fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/numexpr/expressions.py:21
/fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/numexpr/expressions.py:21: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
_np_version_forbids_neg_powint = LooseVersion(numpy.__version__) >= LooseVersion('1.12.0b1')
../../../../../../fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/jupyter_client/connect.py:27
/fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/jupyter_client/connect.py:27: DeprecationWarning: Jupyter is migrating its paths to use standard platformdirs
given by the platformdirs library. To remove this warning and
see the appropriate new directories, set the environment variable
`JUPYTER_PLATFORM_DIRS=1` and then run `jupyter --paths`.
The use of platformdirs will be the default in `jupyter_core` v6
from jupyter_core.paths import jupyter_data_dir
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================= 14 passed, 3 warnings in 37.23s
Independent check of unit tests by [REVIEWER NAME]
[ ] [PLATFORM]:
Functional tests
Ran the SEP0417A week with some cold acquisition temperatures to see the warnings have changed.
Checking star catalog for obsid 49798
Checking star catalog for obsid 18997
/fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/chandra_aca/star_probs.py:423: UserWarning:
Model grid-local-quadratic-2023-05.fits.gz computed between -15 <= t_ccd <= 2, clipping input t_ccd(s) outside that range.
warnings.warn(
Checking star catalog for obsid 49797
/fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/chandra_aca/star_probs.py:423: UserWarning:
Model grid-local-quadratic-2023-05.fits.gz computed between -15 <= t_ccd <= 2, clipping input t_ccd(s) outside that range.
warnings.warn(
Checking star catalog for obsid 49796
/fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/chandra_aca/star_probs.py:423: UserWarning:
Model grid-local-quadratic-2023-05.fits.gz computed between -15 <= t_ccd <= 2, clipping input t_ccd(s) outside that range.
warnings.warn(
Checking star catalog for obsid 49795
/fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/chandra_aca/star_probs.py:423: UserWarning:
Model grid-local-quadratic-2023-05.fits.gz computed between -15 <= t_ccd <= 2, clipping input t_ccd(s) outside that range.
warnings.warn(
Checking star catalog for obsid 49794
/fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/chandra_aca/star_probs.py:423: UserWarning:
Model grid-local-quadratic-2023-05.fits.gz computed between -15 <= t_ccd <= 2, clipping input t_ccd(s) outside that range.
warnings.warn(
Checking star catalog for obsid 49793
/fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/chandra_aca/star_probs.py:423: UserWarning:
Model grid-local-quadratic-2023-05.fits.gz computed between -15 <= t_ccd <= 2, clipping input t_ccd(s) outside that range.
warnings.warn(
Checking star catalog for obsid 49792
/fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/chandra_aca/star_probs.py:423: UserWarning:
Model grid-local-quadratic-2023-05.fits.gz computed between -15 <= t_ccd <= 2, clipping input t_ccd(s) outside that range.
warnings.warn(
Checking star catalog for obsid 19650
/fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/chandra_aca/star_probs.py:423: UserWarning:
Model grid-local-quadratic-2023-05.fits.gz computed between -15 <= t_ccd <= 2, clipping input t_ccd(s) outside that range.
warnings.warn(
Checking star catalog for obsid 19653
Checking star catalog for obsid 19359
Description
Update the temperature clipping for the acquisition model to clip to the range for the current grid-* model. It would be better if this was taken from model itself, but this does not change frequently.
Interface impacts
None
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Ran the SEP0417A week with some cold acquisition temperatures to see the warnings have changed.
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck/starcheck-pr426/combined_diff.txt
New