search

sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Add fid offset support #431

Closed jeanconn closed 8 months ago

jeanconn commented 10 months ago

Description

Moves "expected" position of fid lights to be their positions with chandra_aca.drift.get_fid_offset applied.

The expected positions are used to check if there is a commanded ON fid light within fid-light-search-hw of th expected position and to check if there is a fid light in an acquisition box

This also removes < -14C warning (which was a proxy for fid position).

Interface impacts

Testing

Unit tests

Independent check of unit tests by [REVIEWER NAME]

Functional tests

Output in https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck/starcheck-pr431/

sandbox_starcheck run out of ska3-masters

/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2022/NOV2122/oflsa/ -out nov2122a_25hw # with 25hw box artificially set on Obsid.pm
/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2022/NOV2122/oflsa/ -out nov2122a_40hw # with 40hw box (PR value)
/proj/sot/ska3/flight/bin/skare starcheck -dir /data/mpcrit1/mplogs/2022/NOV2122/oflsa/ -out nov2122a_flight
diff nov2122a_40hw.txt nov2122a_flight.txt > nov2122a_diff.txt
/proj/sot/ska/bin/diff2html nov2122a_flight.txt nov2122a_40hw.txt > nov2122a_diff.html
jeanconn commented 8 months ago

Functional tests rerun at c354581 .