Remove some warnings on acquisition stars. These per-star warnings are no longer relevant as they are issues that are included in the proseco calculation of acquisition probability.
Remove
"Magnitude. Acq star" warnings for acq stars fainter than red or yellow (calculated) mag limits
"Acq Off (padded) CCD" warning
These warnings will be removed for ACQ-only stars but continue for BOT
"Magnitude. MAXMAG - MAG < 0.3"
"Magnitude. MAXMAG %.2f not within 0.1 mag of %.2f" (for maxmag not close to expected value)
Fixes #434
Interface impacts
Testing
Unit tests
[x] Linux
(ska3-masters) jeanconn-fido> git rev-parse HEAD
ca4812dca4e2b459ed7291c8f03e846c1416a846
(ska3-masters) jeanconn-fido> pytest
======================================================================= test session starts ========================================================================
platform linux -- Python 3.10.8, pytest-7.2.1, pluggy-1.0.0
rootdir: /proj/sot/ska/jeanproj/git/starcheck
plugins: timeout-2.1.0, anyio-3.6.2
collected 1 item
starcheck/tests/test_utils.py . [100%]
========================================================================= warnings summary =========================================================================
../../../../../../fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/numexpr/expressions.py:21
../../../../../../fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/numexpr/expressions.py:21
/fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/numexpr/expressions.py:21: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
_np_version_forbids_neg_powint = LooseVersion(numpy.__version__) >= LooseVersion('1.12.0b1')
../../../../../../fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/jupyter_client/connect.py:27
/fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/jupyter_client/connect.py:27: DeprecationWarning: Jupyter is migrating its paths to use standard platformdirs
given by the platformdirs library. To remove this warning and
see the appropriate new directories, set the environment variable
`JUPYTER_PLATFORM_DIRS=1` and then run `jupyter --paths`.
The use of platformdirs will be the default in `jupyter_core` v6
from jupyter_core.paths import jupyter_data_dir
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================== 1 passed, 3 warnings in 32.56s
Independent check of unit tests by [REVIEWER NAME]
Description
Remove some warnings on acquisition stars. These per-star warnings are no longer relevant as they are issues that are included in the proseco calculation of acquisition probability.
Remove
These warnings will be removed for ACQ-only stars but continue for BOT
Fixes #434
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Several recent load weeks run. Output and diffs relative to master at https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck/starcheck-pr437/ . Diffs show expected changes.