search

sot / starcheck

BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Vehicle output has critical warns on commanded fid lights #438

Closed jeanconn closed 6 months ago

jeanconn commented 6 months ago

It looks like starcheck 14.7.0 suffers from a bug I introduced and is now reporting this warning when in vehicle mode.

https://github.com/sot/starcheck/blob/20b7c0a53bc27c0b38cc5d319839cb417a93e625/starcheck/src/lib/Ska/Starcheck/Obsid.pm#L2062

As the fids aren't on if we really are in vehicle mode, this warning is moot.

I think we just shouldn't calculate the fid positions in vehicle mode at

my $fid_positions = get_fid_positions($self, $c);

javierggt commented 6 months ago

Upvoting this one... :-)