Closed taldcroft closed 1 month ago
@jeanconn - is the new 3-digit T_CCD going to break the starcheck parser? How do I test?
I think it is going to break it (as in by eye on that regex it won't match so would return None for that part of the update).
So I think the regex needs a tweak to be fine with more decimals.
For testing, I'd previously just done a functional check like
In [1]: import starcheck.parser
In [2]: test = starcheck.parser.read_starcheck('MAY1324B_test.txt')
In [3]: master = starcheck.parser.read_starcheck('MAY1324B_master.txt')
And confirmed that entries array of dicts were reasonable. I think this would just be the key 'pred_ccd_temp'.
Oh, actually, it looks like the regex by-eye would probably be fine on your proposed change if you are just adding more digits for debug after "C".
@taldcroft Did you mention in our meeting that you were planning to update the description to note that you checked the parser?
@taldcroft Did you mention in our meeting that you were planning to update the description to note that you checked the parser?
Done.
Description
Changes:
Interface impacts
Changes starcheck notes format to add a 3-digit output of the max CCD temperature for diagnostics. No impact to parsing (see functional test below).
Testing
Unit tests
Functional tests
The JUL0824A products showed a critical warning for obsid 26575
Flight (notes for 26575)
Patch (notes for 26575)
As expected, all other obsids showed the new 3-digit representation of the max CCD temperature.
Patch with temporary code to force a violation in 26575
Patched one code line as follows, adding 0.1 to the computed CCD temperature:
This gave:
Compare to flight 14.9.0 release
Format change does not impact parsing