Closed taldcroft closed 3 years ago
Really like this!
I generated a functional test for this change that passes, based on the current ACA model spec. To run this test I created two model files:
I ran each of these using the fewer-dP-pitches
Xija branch, and found they produced identical results.
Thanks @matthewdahmer, very helpful!
@jzuhone - would you be able to run the full regression tests for one of the ACIS checkers?
@taldcroft yes, I will try that this week.
@jzuhone - ping on the ACIS regression tests for this.
Argh, yes. Setting a reminder to do it this week.
@taldcroft all tests pass, so you should be good to go.
Thanks @jzuhone !
Description
The long-term trending of
SolarHeat
power likely has a smoother dependence on pitch than the power itself, and fitting these parameters is often not well constrained. This is sometimes seen as unphysical variations when fitting thedP
(power trending) parameters (effectively overfitting). This PR allows having fewer pitch bins for thedP
parameters.I suspect that having 4 to 6 bins (e.g. [45, 90, 135, 180]) is good enough and reduces the model dimensionality.
In the course of trying to write a test for this which covers all of the different
SolarHeat
subclasses, I ran into a problem that the different subclasses required different positional arguments for various telemetry components. I realized that these telemetry component arguments likepitch_comp
orsimz_comp
could sensibly have defaults set, e.g.'pitch'
and'sim_z'
. This works and in practice is always the same as what gets set in current model specs.The functional part to allow fewer
dP
pitch bins is in 55aa8a5, while the argument munging and some other tidying is in f996b81.Testing
Functional testing
TODO: ensure the full ACIS regression test suite passes.