sot / xija

Thermal modeling framework for Chandra X-ray Observatory
https://sot.github.io/xija
BSD 3-Clause "New" or "Revised" License
9 stars 5 forks source link

Fix instabilities in xija_gui_fit, add ability to adjust error limits in histogram plots #122

Closed jzuhone closed 2 years ago

jzuhone commented 2 years ago

Description

xija_gui_fit occasionally exhibits random crashes, especially when one is attempting to make new plots or pan/zoom within existing plots. This appears to be due to race conditions where an instruction to change a plot is made to a plot object that no longer exists.

Along with https://github.com/sot/Ska.Matplotlib/pull/25, this PR seeks to avoid these crashes by doing the following:

This PR also adds the ability to manually specify the error limits in histogram plots, see the new input boxes in the lower-right of this image:

image

This allows more control over the histogram plots to make them more reproducible.

Testing

Unit tests

Functional tests

jzuhone commented 2 years ago

any comments on this PR?

taldcroft commented 2 years ago

@jzuhone - feel free to merge.