xija_gui_fit occasionally exhibits random crashes, especially when one is attempting to make new plots or pan/zoom within existing plots. This appears to be due to race conditions where an instruction to change a plot is made to a plot object that no longer exists.
Description
xija_gui_fit
occasionally exhibits random crashes, especially when one is attempting to make new plots or pan/zoom within existing plots. This appears to be due to race conditions where an instruction to change a plot is made to a plot object that no longer exists.Along with https://github.com/sot/Ska.Matplotlib/pull/25, this PR seeks to avoid these crashes by doing the following:
Figure
objects as much as possible, instead save theFigure
object and update its dataThis PR also adds the ability to manually specify the error limits in histogram plots, see the new input boxes in the lower-right of this image:
This allows more control over the histogram plots to make them more reproducible.
Testing
Unit tests
Functional tests
xija_gui_fit
, fit a model, create plots, zoom in and out, pan, re-fit, etc. to see if one gets a crash--no crashes occurred