sot / xija

Thermal modeling framework for Chandra X-ray Observatory
https://sot.github.io/xija
BSD 3-Clause "New" or "Revised" License
9 stars 5 forks source link

Apply black and isort formatting and modernize config files #124

Closed taldcroft closed 1 year ago

taldcroft commented 2 years ago

Description

This does the following:

Interface impacts

None

Testing

Unit tests

Independent check of unit tests by [REVIEWER NAME]

Functional tests

Confirmed that the pre-commit hooks work as expected.

matthewdahmer commented 2 years ago

@taldcroft I support this. The only hangup I have is the use of double quotes by default; I find the use of single quotes makes code look better, but this isn't really that big of a deal for me. I generally find the code formatting by black to be quite pleasant to read. I didn't see a way in the black api to ignore specific lines that are intentionally formatted in such a way that would otherwise be re-formatted, is this an option?

taldcroft commented 2 years ago

OK, I'll re-do this PR after #127 and #125 get merged. I will also put in a pre-commit hook config to make it easier to not forget.

After a little while I got used to the double quotes and now they look better. One thing is that I almost always type a single quote and then when I'm done with a section of code I have black fix it with option-shift-f in VS code.