Closed jzuhone closed 2 years ago
@jzuhone - I added a test we should have had long ago which runs every model in chandra_models
. With this test in place I'm good with this PR once you do functional tests, without having really checked the refactor details.
@jzuhone - this is just waiting for those quick functional tests. Let's get this in then I can do the black format PR for xija. :smile:
Hi @taldcroft I ran the functional tests and all looks good.
Description
heat.py
currently contains all of the classes which model heating inputs. Currently, this file is quite bloated, containing all currently used classes, as well as some which are no longer used.This PR refactors this structure, while leaving the API intact, by changing
heat.py
into aheat
subpackage. The files underheat
are now:base.py
: base heating classesgeneric.py
: generic heating classes (this could be merged into the one above potentially)solar.py
: all of the solar heating classesearth.py
: the earthshine in the ACIS radiator FOV codeelectronics.py
: heating from electronics boxesI also put deprecated classes into a new file,
deprecated.py
, under thecomponent
subpackage.This PR also:
DpaSolarHeat
copy of theSolarHeatHrc
classfrom future import print_function
call at the top ofheat.py
Interface impacts
Since this is just code reorganization under the hood, but all imports from the xija API should be the same, there should be no interface impacts.
Testing
Unit tests
Independent check of unit tests by @taldcroft
Functional tests
xija_gui_fit
andacis_thermal_check
tests pass.