search

sot / xija

Thermal modeling framework for Chandra X-ray Observatory
https://sot.github.io/xija
BSD 3-Clause "New" or "Revised" License
9 stars 5 forks source link

Import Ska.engarchive.fetch only when needed #18

Closed taldcroft closed 11 years ago

taldcroft commented 11 years ago

In order to avoid the side effects of importing Ska.engarchive.fetch during installation with setup.py, move the fetch import to the function where fetch is actually called.

cc: @mbaski

p.s. This is the preferred implementation, ignore the clean-init branch / PR #17.

mbaski commented 11 years ago

@taldcroft - This works great, and solves another annoyance where the remote login query line was being output when running the Xija models in MCC (it did not cause problems since there is no stdin the way I run the python interpreter from MATLAB, but it was annoying nonetheless). Thanks Tom. Can this change be included in Skare 0.15 or would you rather wait?

taldcroft commented 11 years ago

@mbaski - I plan to roll up all the changes we've discussed into an updated Skare 0.15. (Should really have tagged this as 0.15-rc1). I have to attend to some other stuff now so won't get to this until later tomorrow or Friday. When were you hoping to start run-for-record testing?

mbaski commented 11 years ago

I’m adding some code per Matt’s request for integration of the Minus-YZ model into MCC, which will take a day or two, so Friday would be great.