search

sot / xija

Thermal modeling framework for Chandra X-ray Observatory
https://sot.github.io/xija
BSD 3-Clause "New" or "Revised" License
9 stars 5 forks source link

Verify that spec-file par names match class-generated par names #39

Closed taldcroft closed 4 years ago

taldcroft commented 8 years ago

Need to make sure this does not impact any existing flight models. Also need to check with model inheritance code.

matthewdahmer commented 8 years ago

@taldcroft Would this impact model element names that use the msid as a part of the name? For example the acis focal plane model uses fptemp instead of the actual msid name fptemp_11 (this does cause an issue in pyger). I would expect an automated system to produce names using the full msid name (e.g. coupling__fptemp_111cbat) where hand editing could use alternative forms (e.g. couplingfptemp__1cbat).

taldcroft commented 4 years ago

Not worth the validation testing and potential problems.