Closed jzuhone closed 5 years ago
ping @jeanconn also
Here is a screenshot of the ACA model I fit:
And the JSON model file is in this gist: https://gist.github.com/a5ba50faf33c26a8e273e3768f56dabd
The bad data gap should extend to 2018:293:00:00:00. Before that there is a clear excess from the HRMA being abnormally hot.
Ready for deploy to GRETA test. Needs ACA starcheck / ska_testr + LR approval for install to Ska flight.
For Ska flight and LR, are the ska_testr tests enough to show this is a no-op for the non-ACA models, or do we need ACIS to explicitly test? (Also, I was planning to install to /proj/sot/ska/dev on GRETA, I can't remember if we really call that GRETA test).
There is no need in my opinion for ACIS to test, since the new class will not be brought into our models now and there are no other changes.
Who should bring this forward for LR approval?
I can bring the xija change as a "starcheck" change to LR.
This PR originated in a request from @taldcroft regarding the ACA model. It applies a constant power after a particular moment in time, and zero otherwise. The constant power is a fitted parameter.
I still need to do some more testing of this on the ACA model, but I'm putting it up here for initial comments.