Closed matthewdahmer closed 5 years ago
@taldcroft Per your suggestion, I added a test to ensure the new pitch range is being used, and corrected the version tag.
Plan out of TWG is for ACIS to test models from this branch and for @jeanconn to functionally check starcheck before merging this.
WRT starcheck testing: I set up a test environment with xija 4.14 pip-installed, and ran the starcheck regression test set (11 loads run with ACA thermal model) and MAY2019A. No thermal-model-related diffs and no errors out of starcheck with xija 4.14.
I checked the production DPA, DEA, and ACISFP models, which do have definition past 170, and found only very minor differences in prediction accuracy. The differences I observed do not warrant a refit to support Xija 4.14. I am waiting for agreement from ACIS before posting the results to the TWiki.
@matthewdahmer I saw your plots and they look good, I will try to look at the DEA, FP temp, and PSMC models tomorrow (at home today with sick kid). @Gregg140 will have to comment on his tests of the DPA model.
I, too, ran comparisons between the old xija code and the new on the 1DPAMZT model time slices. There were very small though discernable differences. The update looks good to me.
You had not yet received John Zuhone's comments/approval before merging it, though he was invited to approve.
The Focal Plane model is just as affected as 1DPAMZT.
I don't anticipate disagreeing with @matthewdahmer, but I do want to take a look at it before we promote it. I can do that tonight.
@Gregg140 - oops, sorry, I misread that @jzuhone had delegated to you. We'll hold on doing anything with the new xija.
Ok, this looks good to me after some analysis.
This expands the upper end of the supported pitch range from 170 degrees (169.999 degrees) to 180 degrees (179.999 degrees) to reflect the expanded allowable pitch range being explored.