Add optional bias parameters for ACIS SolarHeat subclasses for ACIS sim positions

sot / xija

Thermal modeling framework for Chandra X-ray Observatory

https://sot.github.io/xija

BSD 3-Clause "New" or "Revised" License

9 stars 5 forks source link

Add optional bias parameters for ACIS SolarHeat subclasses for ACIS sim positions #68

Closed jzuhone closed 5 years ago

jzuhone commented 5 years ago

This PR adds bias parameters for ACIS sim positions to the ACIS-specific SolarHeat subclasses, which helps with the ACIS focal plane model. It is designed in such a way so that these parameters must be explicitly set in the JSON model spec file in order to be used, thus ensuring backwards-compatibility.

I also changed the logging level in gui_fit to avoid voluminous debug-level messages from Matplotlib on startup.

jzuhone commented 5 years ago

Declining this PR because upon further review this did not improve model accuracy substantially.