search

sot / xija

Thermal modeling framework for Chandra X-ray Observatory
https://sot.github.io/xija
BSD 3-Clause "New" or "Revised" License
9 stars 5 forks source link

[bugfix] Wrong line is updated in gui_fit #83

Closed jzuhone closed 4 years ago

jzuhone commented 4 years ago

Description

This is a quick hotfix for gui_fit (I am a bit sheepish about this). During a fit, the data line is being updated in the plot with the model instead of the model line.

This does not affect the model propagation or fitting, and at the end of the fit the model and data lines are correct, but this should fix the model misleadingly looking like a perfect fit while the fit is running.

Testing

Fixes #

jzuhone commented 4 years ago

sorry @taldcroft. @Gregg140 this probably explains something you saw that was odd a few weeks back if I remember right.

taldcroft commented 4 years ago

Yes that is what I saw but forgot about it.

Gregg140 commented 4 years ago

Yes you fixed it in the acis py ska version.

jzuhone commented 4 years ago

@Gregg140 if I did I must have forgotten about it.