search

sot / xija

Thermal modeling framework for Chandra X-ray Observatory
https://sot.github.io/xija
BSD 3-Clause "New" or "Revised" License
9 stars 5 forks source link

Allow pathlib Path/PosixPath as model_spec #98

Closed jeanconn closed 4 years ago

jeanconn commented 4 years ago

It looks like:

https://github.com/sot/xija/blob/64b81084e1a4c21c500eb8cd7fdb1d12dc068e73/xija/model.py#L108

only allows model_spec files as string filenames.

taldcroft commented 4 years ago

The problem is actually here: https://github.com/sot/xija/blob/64b81084e1a4c21c500eb8cd7fdb1d12dc068e73/xija/model.py#L107

jeanconn commented 4 years ago

Right, I saw that and understood the reason why, but should have linked the line up for clarity.

jeanconn commented 4 years ago

And then a question about if six should be removed, if this should be handled with a try-to-read or some such, or if the user should just do what I did in my dev perigee_health_plots and str(PosixPath).