search

sotch-pr35mac / syng

A free, open source, cross-platform, Chinese-To-English dictionary for desktops.
https://getsyng.com
GNU General Public License v3.0
159 stars 24 forks source link

Javascript's `alert` dialog no longer works. #101

Closed sotch-pr35mac closed 6 years ago

sotch-pr35mac commented 6 years ago

The build in alert() method only shows square brackets where characters should be. This method is used throughout the program, especially for displaying errors or other information like that. For example, when trying to study flashcards with no bookmarks.

Must find a new method to use to display this information.

sotch-pr35mac commented 6 years ago

electron's showMessageBox is probably the best way to remedy this issue: https://github.com/electron/electron/blob/v0.36.6/docs/api/dialog.md

sotch-pr35mac commented 6 years ago

This issue does not effect the Windows version

sotch-pr35mac commented 6 years ago

This issue also does not effect the macOS version.

sotch-pr35mac commented 6 years ago

I can't reproduce this on Ubuntu, and believe that it only effects Fedora systems (the system I am using), so I am marking this as won'tfix because it effects so little systems, and closing the issue.