sotch-pr35mac / syng

A free, open source, cross-platform, Chinese-To-English dictionary for desktops.
https://getsyng.com
GNU General Public License v3.0
159 stars 24 forks source link

For Longivity, Please Make Flathub #175

Open XingShelly opened 2 years ago

XingShelly commented 2 years ago

Please create a flathub or an appimage of it, so that even if the dependencies become old, at least it would still work.

tinywrkb commented 2 years ago

I looked at this today. Building from source is not practical due to Flathub's no network policy when building an application on the CI, and the usage of neon here.
If there is a published binary release as a tarball, deb, or even appimage, then it should be pretty easy to repackage it as a Flatpak.

sotch-pr35mac commented 2 years ago

I'm working on migrating the v2 beta from Electron to Tauri. It looks like there's some discussion going on in the Tauri community for out-of-the-box flatpak packaging, but at the very least it looks like there's good support and documentation around packaging AppImages. I know this isn't helpful for v1, but hopefully we can avoid the dependency issues moving forward.

tinywrkb commented 2 years ago

I never packaged a Tauri app, but if it uses Cargo, there's nothing extra that isn't included in Cargo.lock, and we can build the Tauri app with $ cargo --offline .., then maybe we can use flatpak-cargo-generator.py to package and build the app from source.
And as I said before, at worst, it's possible to repackage the binary release, preferably the deb or tarball should be used, but if there's only an appimage, then it can also work.

sotch-pr35mac commented 2 years ago

From the looks of it there's out-of-the-box support for packaging .deb, so that might also work. I'll report back here after I've completed the migration to Tauri and hopefully we can get some packaging setup with CI.

sotch-pr35mac commented 1 year ago

Now that we've migrated to Tauri, we can build with cargo tauri build, but we also have .deb and .AppImage build artifacts. I imagine it may be easier to repackage the binaries instead of building from source since Tauri doesn't simply use cargo build.

tinywrkb commented 1 year ago

@sotch-pr35mac thanks for the update. I will look at this in a couple of weeks.