sotch-pr35mac / syng

A free, open source, cross-platform, Chinese-To-English dictionary for desktops.
https://getsyng.com
GNU General Public License v3.0
156 stars 24 forks source link

[Bug] Search does not work when not using mainland chinese pronounciations #233

Open null-von-sushi opened 1 year ago

null-von-sushi commented 1 year ago

If you search using pinyin for lese nothing shows up, while searching for laji correctly shows 垃圾 as one of the search results

sotch-pr35mac commented 11 months ago

Right now, the only supported search features are English, characters (simplified + traditional), pinyin with tone marks, pinyin with tone numbers, and toneless pinyin. Other pronunciation methods are not supported.

I'm open to including an option to support additional pronunciation methods, but I don't have a data source to support that backing. If this is something you'd like to see included in a future version of Syng, feel free to leave some suggestions and I'd be open to adding this feature.

null-von-sushi commented 8 months ago

Thanks. What I was referring to would still be Pinyin, however Mainland China and Taiwan pronunciations differ with some words, and searching Syng currently does not currently show any results unless the Mainland China pronunciation is used.

I am not sure of any way to easily add this programmatically, but CC-CEDICT (accessible onlinehere or as a database file here has notes for each entry where Taiwanese pronunciation would be different. Just search for Taiwan pr..

As an example (for 垃圾 again): trash / refuse / garbage / (coll.) of poor quality / Taiwan pr. [le4 se4] But searching lese or le4 se4 does not seem to work yet.

Out of curiosity, does Sync use a local file for it's dictionary database? I'd like to have a little play around with it to see if I can maybe use a custom CC-CEDICT-compatible database (which Sync is using already I believe), however I am not sure what file the database itself is stored in.