Closed asterictnl-lvdw closed 2 years ago
Thank you for your continued development of the tool. At this time, we cannot merge the full PR as it is. The additional CIS inspectors are not called via any methods, updates to the html template and 365Inspect.ps1 files return bracketed values for the included inspectors, and 16 of the 36 CIS inspectors duplicate current inspectors.
We have pulled down your repo and will selectively include the changes that make sense, add the new functionality of Default and Expected Values, and will make sure to credit you for those items. We hope to have these enhancements integrated soon.
@ThoughtContagion
Thank you for your reply.
I am happy that you are at least taking a look and considering implementing partial functions. For now I hope:
I only focused on the CIS benchmark for now. If I find it necessary to make more audit scripts for different modules to check I will do research and check if it is possible.
Kind regards,
~Leonardo van de Weteringh
@asterictnl-lvdw
We appreciate the continued interest in and furthering of the tool!
The non-duplicate CIS inspectors are great additions to the tool, as are the default and expected value fields. We have been slowly working to integrate those fields from your previous feature requests, the work you've done here certainly should help expedite those additions. Where it makes sense with the items being incorporated, we'll ensure that the relevant portions of the README file reflect your suggested changes.
Thank you!
The following changes have been made: