sotetsuk / pgx

♟️ Vectorized RL game environments in JAX
http://sotets.uk/pgx/
Apache License 2.0
387 stars 25 forks source link

[Mahjong] Reduce compilation/run time of `_pass()` #1122

Closed OkanoShinri closed 9 months ago

OkanoShinri commented 9 months ago

cf. https://github.com/sotetsuk/pgx/issues/1070

OkanoShinri commented 9 months ago
function name # expr lines compile time running time
_pass 8539 2526.0ms 223.7μs
function name # expr lines compile time running time
_pass 7231 2334.7ms 144.3μs
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (674a9d7) 88.08% compared to head (72d9d1f) 88.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1122 +/- ## ======================================= Coverage 88.08% 88.09% ======================================= Files 60 60 Lines 5918 5922 +4 ======================================= + Hits 5213 5217 +4 Misses 705 705 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OkanoShinri commented 9 months ago

@sotetsuk test通ったのでマージして良いですか!

sotetsuk commented 9 months ago

お願いします👍🙏@OkanoShinri