sotetsuk / pgx

♟️ Vectorized RL game environments in JAX
http://sotets.uk/pgx/
Apache License 2.0
372 stars 23 forks source link

[API] Deprecate `player_id` in `Env.observe` #1159

Open sotetsuk opened 6 months ago

sotetsuk commented 6 months ago

1154

While, this feature makes the implementation complicated, this feature is rarely used because we are interested in the observation of current player to act.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8575a3f) 88.10% compared to head (82a3f19) 88.10%.

Files Patch % Lines
pgx/core.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1159 +/- ## ========================================== - Coverage 88.10% 88.10% -0.01% ========================================== Files 64 64 Lines 5996 6000 +4 ========================================== + Hits 5283 5286 +3 - Misses 713 714 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.