Reduce exports from SotoSignerV4

[codecov[bot]]

Codecov Report

Merging #567 (fcc1b4c) into 7.x.x (15744ff) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##            7.x.x     #567   +/-   ##
=======================================
  Coverage   78.87%   78.87%           
=======================================
  Files          71       71           
  Lines        6292     6292           
=======================================
  Hits         4963     4963           
  Misses       1329     1329           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[adam-fowler]

Reducing exports is always good - is there any reason why these are needed at all for v7?

I think it is a good idea to export the symbols my public APIs use. Makes it easier for the end user.

[0xTim]

Oh completely agree - are things like ByteBuffer going to be part of the public API though?

(This is a more general question as opposed to being specifically about this PR, I know removing all the future APIs is a multi step process)

[adam-fowler]

ByteBuffer is part of the public API. I don't think that is going to change. Unless we get the bag of bytes type in the sodlib

[0xTim]

🤦‍♂️ travel brain getting futures and byte buffers mixed up