Closed 0xTim closed 1 year ago
Merging #568 (a1cdf37) into main (8b37e06) will decrease coverage by
0.02%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #568 +/- ##
==========================================
- Coverage 77.14% 77.12% -0.02%
==========================================
Files 87 87
Lines 8557 8557
==========================================
- Hits 6601 6600 -1
- Misses 1956 1957 +1
see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
That didn't seem to work
Hmm this is weird, it was the swift build
command that just failed. I've noticed slower bios times on the Vapor side with CodeQL enabled, I might have to raise that in Slack
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.
It seems happy now
This removes the environment variable as Swift is out of beta so no longer needed. It also removes some permissions that are only required for private repositories.
We could also run this on Linux as CodeQL now supports 5.8 and Linux properly, but I've left it as macOS. Happy to switch it to Linux if it makes it easier (currently in Vapor I've opted for both to catch any issues just in case)