Deprecated member initializers

soto-project / soto

Swift SDK for AWS that works on Linux, macOS and iOS

https://soto.codes

Apache License 2.0

875 stars 83 forks source link

Deprecated member initializers #557

Closed adam-fowler closed 2 years ago

adam-fowler commented 2 years ago

For shapes with deprecated member variables

Remove deprecated variables from standard init function
Add an additional init which is flagged as deprecated which includes deprecated variables

Soto Code generator PR is https://github.com/soto-project/soto-codegenerator/pull/34 This resolves #352

0xTim commented 2 years ago

Is there a reason to keep a deprecated initialiser around if we're prepping a major release?

adam-fowler commented 2 years ago

Is there a reason to keep a deprecated initialiser around if we're prepping a major release?

These are variables deprecated by AWS. I won't be able to tell the difference between a newly deprecated variable and one deprecated prior to v6, so won't know if I can delete it. So am just sticking to deprecating all of them. AWS's versioning of model files is separate from the Soto version.