search

sotopia-lab / sotopia-demo

MIT License
0 stars 0 forks source link

Enable editable scenarios #7

Closed bugsz closed 4 weeks ago

bugsz commented 1 month ago

The same as #6, but in a new branch name. The first commit addresses #3, and the following commits address #4

Btw whether the scenario is editable does not relate to the omniscient? (i.e. we can still only show partial information while making the scenario editable?)

XuhuiZhou commented 1 month ago

Good point! This is just a feature that I am suggesting. Cuz once people want to edit things, that usually implies they want full control. This is basically making things easier to handle.

XuhuiZhou commented 1 month ago

@bugsz thanks for the update, some new feedback Screenshot 2024-08-14 at 12 14 49 PM

bugsz commented 1 month ago

Still in progress.. Currently support the flexible choice of agents (including human-human and model-model interaction)

bugsz commented 1 month ago

A bit strange behavior on my end: Now I can edit the scenario and agent bg. I can see the change reflected in the environment (and also in LLMAgent.inbox). But I did not see the conversation change as expected (for example, I make one agent to be giselle does not want to talk but the conversation is still long. @XuhuiZhou Is it possible for you to see what's happening?

XuhuiZhou commented 1 month ago

A bit strange behavior on my end: Now I can edit the scenario and agent bg. I can see the change reflected in the environment (and also in LLMAgent.inbox). But I did not see the conversation change as expected (for example, I make one agent to be giselle does not want to talk but the conversation is still long. @XuhuiZhou Is it possible for you to see what's happening? Try debugging by outputting the agent prompt?

XuhuiZhou commented 4 weeks ago

Also, I notice that we use the callback functions. Any chance you can update the readme to introduce/explain that concept? @bugsz

bugsz commented 4 weeks ago

@XuhuiZhou I think ready to merge!