Fix: add fixed hiredis version

sotopia-lab / sotopia

Sotopia: an Open-ended Social Learning Environment (ICLR 2024 spotlight)

https://docs.sotopia.world

MIT License

166 stars 21 forks source link

Fix: add fixed hiredis version #210

Closed yufansong closed 1 month ago

yufansong commented 1 month ago

Meet problem in #209, fixed the new hiredis version in pyproject.toml

Closes #

📑 Description

✅ Checks

[ ] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed
[ ] Branch name follows type/descript (e.g. feature/add-llm-agents)
[x] Ready for code review

ℹ Additional Information

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.53%. Comparing base (2a51167) to head (94595b2). Report is 2 commits behind head on main.

@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   71.53%   71.53%           
=======================================
  Files          55       55           
  Lines        2863     2863           
=======================================
  Hits         2048     2048           
  Misses        815      815

ProKil commented 1 month ago

What is the compatible range of hiredis? I am basically concerned about pinning it to a strict version.

yufansong commented 1 month ago

Please at least use >=3.0.0

Open a PR #216