sotopia-lab / sotopia

Sotopia: an Open-ended Social Learning Environment (ICLR 2024 spotlight)
https://docs.sotopia.world
MIT License
168 stars 21 forks source link

Fix: change hiredis version to >= 3.0.0 #216

Closed yufansong closed 1 month ago

yufansong commented 1 month ago

Solve the proposal here https://github.com/sotopia-lab/sotopia/pull/210#pullrequestreview-2348449834

Closes #

📑 Description

✅ Checks

ℹ Additional Information

XuhuiZhou commented 1 month ago

@yufansong I think I got it covered in https://github.com/sotopia-lab/sotopia/pull/214

basically, redis om should have handled the version of Hiredis and now it's good.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.26%. Comparing base (a7a9adc) to head (b7a244f). Report is 4 commits behind head on main.

@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   71.26%   71.26%           
=======================================
  Files          55       55           
  Lines        2875     2875           
=======================================
  Hits         2049     2049           
  Misses        826      826