Update sampler in server configuration

ProKil commented 3 months ago

Closes #

📑 Description

✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[x] I have updated the documentation as required
[x] All the tests have passed
[x] Branch name follows type/descript (e.g. feature/add-llm-agents)
[x] Ready for code review

ℹ Additional Information

XuhuiZhou commented 3 months ago

Then how can we choose to use different samplers in an easy way? I think it does not make sense to bury the hyper parameter that deep?

On Tue, Mar 19, 2024 at 11:50 AM Hao Zhu @.***> wrote:

@.**** commented on this pull request.

In sotopia_conf/server_conf/server.gin https://github.com/sotopia-lab/sotopia/pull/33#discussion_r1530653376:

@@ -14,3 +15,4 @@ server.run_async_server: using_async=True tag=%TAG omniscient=%OMNISCIENT

@.***()

The reason is that you have to import sotopia in the gin configuration. This is not possible from command line arguments, and should not be recommended to our users.

— Reply to this email directly, view it on GitHub https://github.com/sotopia-lab/sotopia/pull/33#discussion_r1530653376, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE35IXK6OXO4U2YOS6MTOJLYZBNCZAVCNFSM6AAAAABE2NYW7GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBWGY3TSMJZGQ . You are receiving this because you commented.Message ID: @.***>

ProKil commented 3 months ago

I know what you mean, let me add an example of using sotopia.server.run_async_server directly. From the perspective of the sotopia package, it is actually well exposed. sotopia_conf is merely a recommended way to config the experiments.

sotopia-lab / sotopia