Update server.py - Githubissues

sotopia-lab / sotopia

Sotopia: an Open-ended Social Learning Environment (ICLR 2024 spotlight)

https://docs.sotopia.world

MIT License

127 stars 16 forks source link

Update server.py #94

Closed Armxyz1 closed 2 weeks ago

Armxyz1 commented 2 weeks ago

Closes #

📑 Description

A small spelling change from simutaneous to simultaneous, in server.py.

✅ Checks

[x] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed
[ ] Branch name follows type/descript (e.g. feature/add-llm-agents)
[x] Ready for code review

ℹ Additional Information

ProKil commented 2 weeks ago

Thanks @Armxyz1 !

ProKil commented 2 weeks ago

Hi @Armxyz1 Thanks for you contribution! Sorry the github workflow was not set up right, so the CI check didn't run properly. Would you mind merging ci/ci-pr-trigger into your PR? Or alternatively we can wait until #96 is merged and then merge main into your PR.

Armxyz1 commented 2 weeks ago

Hi @Armxyz1 Thanks for you contribution! Sorry the github workflow was not set up right, so the CI check didn't run properly. Would you mind merging ci/ci-pr-trigger into your PR? Or alternatively we can wait until #96 is merged and then merge main into your PR.

Should be done now. Please verify.

ProKil commented 2 weeks ago

Thanks!

Would you mind changing parallel.py as well? There are four "simutaneous"es https://github.com/Armxyz1/sotopia/blob/434bf5425d7081912f4b6b57abb9b2312ad84324/sotopia/envs/parallel.py#L130

Armxyz1 commented 2 weeks ago

Thanks!

Would you mind changing parallel.py as well? There are four "simutaneous"es https://github.com/Armxyz1/sotopia/blob/434bf5425d7081912f4b6b57abb9b2312ad84324/sotopia/envs/parallel.py#L130

Done!